without CTS, our types allow invalid handler #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you must either specify the jsonschemas or enable (deprecated) proxy mode handler<E,T>(fn) types say that the state should be of type T, but if the user specifies T has a Cell<...> it will be stripped away by the compiler - and so our runtime won't know - and it was enabling proxy mode we should only enable proxy mode if the user explicitly specifies.
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files. Review in cubic
|
@anotherjesse all ready to merge? |
jakedahn
added a commit
that referenced
this pull request
Aug 4, 2025
jakedahn
added a commit
that referenced
this pull request
Aug 5, 2025
jakedahn
added a commit
that referenced
this pull request
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you must either specify the jsonschemas or enable (deprecated) proxy mode
handler<E,T>(fn) types say that the state should be of type T, but if the user specifies T has a Cell<...> it will be stripped away by the compiler - and so our runtime won't know - and it was enabling proxy mode
we should only enable proxy mode if the user explicitly specifies.
Summary by cubic
Updated the handler function to require either explicit JSON schemas or proxy mode to prevent invalid handler types from being accepted.